Support custom openapi url #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdebrauwer
requested changes
Feb 16, 2022
Comment on lines
38
to
41
| if(isset($json['servers'])) { | ||
| return $json; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if(isset($json['servers'])) { | |
| return $json; | |
| } | |
| if ((bool) config('swagger-ui.modify_file')) { | |
| return $json; | |
| } |
can you add this instead? By adding the a modify_file boolean config variable, we still have the option to provide an external file where we do want to change the servers and the securitySchemes
This can be applied to configureOAuth method as well.
Can you also add a test for this?
There was a problem hiding this comment.
I'm a beginner in testing, can you check it out?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to do according to your suggestion. What do you think about it?