fix: use full url for Swagger Ui bundles urls #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I wanted to use your package on an application hosted in a subdirectory (like
https://example.net/my-laravel-application/
), but it failed to load the Swagger bundle because the link is generated from the root of the application.This proposed change fixes this behaviour by using the
url()
helper to generate a fully qualified link to the openapi file.I failed to add a unit test 馃槶
I tried to add a unit test to test for this behaviour, but I couldn't get it to work correctly.
url()
helper doesn't use the config fromapp.url
in the CLI (as far as I can say)URL::forceRootUrl(config('app.url'));
, but then the request gives a 404 as the test request now includes the subdir in it's pathprepareUrlForRequest()
method to remove theurl()
helper call from it, but I'm not keen to override a framework method. It works though.