Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason for all the weird linebreaks in flexsearch.js? #43

Closed
samuelpath opened this issue Feb 14, 2019 · 2 comments
Closed

Any reason for all the weird linebreaks in flexsearch.js? #43

samuelpath opened this issue Feb 14, 2019 · 2 comments

Comments

@samuelpath
Copy link

I say weird, but I should rather say… unconventional.

Like:

while(i < length){

                        tmp = arr[i++];

                        const index = "@" + tmp;

                        if(check[index]){

Are they on purpose?

If so, what is their purpose?

If not, could using tools like Prettier (or Prettier + ESLint) help?

@ts-thomas
Copy link
Contributor

Unconventional measured on which convention? Sadly there is no ultimate convention. And one of them I follow is that between a declaration of a new variable (const index ...) is a blank line. That's all.

@ts-thomas
Copy link
Contributor

By the way I use app.codacy.com with almost every option enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants