-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial end-to-end tests #5
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/iaincollins/next-auth-example/lelf1m28e |
Hey this is fantastic! <3 I was thinking we would add the tests to the actual (If I implied we should add the tests here and that was confusing! If you just felt that this is an easier place to put them, no problem.) This is all I can come up with off the top of my head: Advantages
Disadvantages
Welcome your thoughts! I am completely cool with "actually this is easier for now, can we look at that later". :-) |
In the meantime, I will get on with making that Docker container and try running these tests against it to see how far I get! Just a heads up that I think that might take me a few days to get round to as a few things going on this week! Thanks again for doing this and look forward to working more on it! |
PS: I love how simple this is, this is wild! Good call on cypress. Good catch on the Email label, I've been meaning to fix that accessibility issue - will add one. |
@iaincollins That's my bad! I mistook I'll probably add a few more of the tests I mentioned in the PR (just accessing the URLs directly for now as it's simpler, rather than trying to create a 'signin' workflow test) |
Oh that is totally on me! 😂 Communicating via tickets is hard! That would be awesome! Agree, starting by testing URLs seems like a good approach! I will tag you when I raise a PR that has a command like |
I've never done it before, but the Cypress docs on environment variables suggest you can set |
Superseded by iaincollins/next-auth #298. |
This PR adds some initial end-to-end tests using Cypress. Testing Library is used for the cypress tests to make best-practise tests easier to write and easier to read.
Completed Tests
/api/auth/signin
):api/auth/signout
):/api/auth/veritfy-request
)/api/auth/error
):/
):Issues