fix: make OAuth 1 work after refactoring (#1218)

* chore: add twitter provider to dev app

* feat: bind client instance to overriden methods

* fix: don't add extra params to getOAuthRequestToken

* chore: add twitter to env example, add secret gen instructions

.env.local.example

@@ -1,6 +1,15 @@
 # Rename file to .env.local and populate values
 # to be able to run the dev app
+
 NEXTAUTH_URL=http://localhost:3000
-SECRET=
+SECRET= Linux: `openssl rand -hex 32` or https://generate-secret.now.sh/32
+
+AUTH0_ID=
+AUTH0_DOMAIN=
+AUTH0_SECRET=
+
 GITHUB_ID=
-GITHUB_SECRET=
+GITHUB_SECRET=
+
+TWITTER_ID=
+TWITTER_SECRET=

pages/api/auth/[...nextauth].js

@@ -13,7 +13,11 @@ export default NextAuth({
       clientSecret: process.env.AUTH0_SECRET,
       domain: process.env.AUTH0_DOMAIN,
       protection: "pkce"
-    })
+    }),
+    Providers.Twitter({
+      clientId: process.env.TWITTER_ID,
+      clientSecret: process.env.TWITTER_SECRET,
+    }),
   ],
   // Database optional. MySQL, Maria DB, Postgres and MongoDB are supported.
   // https://next-auth.js.org/configuration/databases

src/server/lib/oauth/client.js

@@ -39,7 +39,7 @@ export default function oAuthClient (provider) {
   )
 
   // Promisify get() and getOAuth2AccessToken() for OAuth1
-  const originalGet = oauth1Client.get
+  const originalGet = oauth1Client.get.bind(oauth1Client)
   oauth1Client.get = (...args) => {
     return new Promise((resolve, reject) => {
       originalGet(...args, (error, result) => {
@@ -50,7 +50,7 @@ export default function oAuthClient (provider) {
       })
     })
   }
-  const originalGetOAuth1AccessToken = oauth1Client.getOAuthAccessToken
+  const originalGetOAuth1AccessToken = oauth1Client.getOAuthAccessToken.bind(oauth1Client)
   oauth1Client.getOAuthAccessToken = (...args) => {
     return new Promise((resolve, reject) => {
       originalGetOAuth1AccessToken(...args, (error, accessToken, refreshToken, results) => {
@@ -62,7 +62,7 @@ export default function oAuthClient (provider) {
     })
   }
 
-  const originalGetOAuthRequestToken = oauth1Client.getOAuthRequestToken
+  const originalGetOAuthRequestToken = oauth1Client.getOAuthRequestToken.bind(oauth1Client)
   oauth1Client.getOAuthRequestToken = (...args) => {
     return new Promise((resolve, reject) => {
       originalGetOAuthRequestToken(...args, (error, oauthToken) => {

src/server/lib/signin/oauth.js

@@ -33,7 +33,7 @@ export default async function getAuthorizationUrl (req) {
   }
 
   try {
-    const oAuthToken = await client.getOAuthRequestToken(provider.callbackUrl)
+    const oAuthToken = await client.getOAuthRequestToken()
     const url = `${provider.authorizationUrl}?oauth_token=${oAuthToken}`
     logger.debug('GET_AUTHORIZATION_URL', url)
     return url