Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): convert Keycloak to TS, add picture by default #2851

Merged
merged 1 commit into from Sep 28, 2021

Conversation

balazsorban44
Copy link
Member

Slight iteration on #2485 to add a profile picture by default, so it is more consistent with other Provider defaults:

To achieve this, I opened up the Keycloak Admin Console, and under Users -> User -> Attributes, I added a picture attribute pointing to our logo, which is hen mapped in the profile callback.

@codecov-commenter
Copy link

Codecov Report

Merging #2851 (94fc651) into beta (c2fd58d) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta    #2851   +/-   ##
=======================================
  Coverage   14.03%   14.03%           
=======================================
  Files          85       85           
  Lines        1361     1361           
  Branches      387      387           
=======================================
  Hits          191      191           
  Misses       1105     1105           
  Partials       65       65           
Impacted Files Coverage Δ
src/providers/keycloak.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2fd58d...94fc651. Read the comment docs.

@balazsorban44 balazsorban44 changed the title fix(providers): convert to Keycloak to TS add picture by default fix(providers): convert Keycloak to TS, add picture by default Sep 28, 2021
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@balazsorban44 balazsorban44 merged commit 9e1eab0 into beta Sep 28, 2021
@balazsorban44 balazsorban44 deleted the fix/keycloak branch September 28, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants