-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Keycloak provider #2485
add Keycloak provider #2485
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/8Rrr2Nv7aWb8AipCyYN1sRcfF8si |
Awesome, so I assume you were able to get it to work! 🎉 I will have a closer look. From now on, I will want us to enforce stricter defaults for built-in providers for consistency, and I also want to see if we can get an account on the provider platform for testing purposes before merging. But this looks promising. |
Yep, and I just tested with please-open.it. To reproduce:
|
Apart from testing this in our stack, is there something we can do to help moving this forward? |
I just want to have a look myself before merging. Just use the source code as a custom provider if you need this already. Currently busy with migrating our adapters. There is also a merge conflict. @bbigras could you address that please? |
@balazsorban44 Done. It seems a rebase was enough. |
Codecov Report
@@ Coverage Diff @@
## next #2485 +/- ##
==========================================
- Coverage 11.52% 11.48% -0.04%
==========================================
Files 84 85 +1
Lines 1319 1323 +4
Branches 378 378
==========================================
Hits 152 152
- Misses 970 974 +4
Partials 197 197
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, finally got around to check this out! 👍 Looks good, I only had a small comment/suggestion. Other than that, it is good to go!
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Done. Do you want me to squash it, or do you want to do it while merging or something? |
It's merged! Give me a sec, and I'll release it too. Here it is: |
@balazsorban44 |
Absolutely, Check out the migration as well: https://docs-nextauthjs.vercel.app/getting-started/upgrade-v4 |
I downloaded the version, but I was trying to use it like the previous versions. Thank you so much! |
* add Keycloak provider * Update src/providers/keycloak.js Co-authored-by: Balázs Orbán <info@balazsorban.com> Co-authored-by: Balázs Orbán <info@balazsorban.com>
Reasoning 💡
Add a Keycloak provider.
I tested with a self-hosted Keycloak.
I based this PR on the auth0 provider.
I was first wondering if it was possible in #2411 (comment).
Checklist 🧢
Affected issues 🎟
Related: #1261