Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] openid-client listed as peerDependency, but it's not #6142

Closed
MonstraG opened this issue Dec 22, 2022 · 2 comments
Closed

[Docs] openid-client listed as peerDependency, but it's not #6142

MonstraG opened this issue Dec 22, 2022 · 2 comments
Labels
documentation Relates to documentation good first issue Good issue to take for first time contributors

Comments

@MonstraG
Copy link

What is the improvement or update you wish to see?

https://next-auth.js.org/errors says:

...it might have happened due to openid-client (which is peer dependency) node version mismatch.

openid-client is not a peer dependency according to this:

https://github.com/nextauthjs/next-auth/blob/main/packages/next-auth/package.json#L75

I also tried to click Edit this page at the bottom, but that sent me to

https://github.com/nextauthjs/next-auth/edit/main/docs/docs/errors.md

which returned 404.

Is there any context that might help us understand?

n/a

Does the docs page already exist? Please link to it.

https://next-auth.js.org/errors

@MonstraG MonstraG added documentation Relates to documentation triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Dec 22, 2022
balazsorban44 added a commit that referenced this issue Dec 22, 2022
@balazsorban44
Copy link
Member

balazsorban44 commented Dec 22, 2022

I guess the wording can be misleading, it was meant to say "a dependency we rely on", not as peerDepdendencies. Fixed the "Edit this page" button. If you want to opene one, a PR should be opened against the v4 branch, thank you! 🙏

@balazsorban44 balazsorban44 added good first issue Good issue to take for first time contributors and removed triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Dec 24, 2022
@iswarmondal
Copy link
Contributor

Hey @balazsorban44, let me rephrase the words and create a PR accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation good first issue Good issue to take for first time contributors
Projects
None yet
Development

No branches or pull requests

3 participants