Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub App Login Failure with Missing Permissions and Absence of Public Email #7777

Open
leonschwanitz opened this issue Jun 12, 2023 · 0 comments
Open

GitHub App Login Failure with Missing Permissions and Absence of Public Email #7777

leonschwanitz opened this issue Jun 12, 2023 · 0 comments
Labels
enhancement New feature or request triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.

Comments

@leonschwanitz
Copy link

leonschwanitz commented Jun 12, 2023 •
edited
Loading

Description 📓

When the "Account permissions -> email addresses (read)" permission is not granted, Next.js Auth throws an error (with the Prisma Adapter) indicating that the email address cannot be found. Additionally, a client-side error occurs (OAuthCreateAccountError). It would be beneficial for Next.js Auth to throw an error named "PermissionMissing" or "EmailMissing" instead.

How to reproduce ☕️

Create a GitHub App without setting any permissions, and then attempt to log in using Next.js Auth. Ensure that you do not have a public email associated with your GitHub account.
@leonschwanitz leonschwanitz added enhancement New feature or request triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Jun 12, 2023
leonschwanitz added a commit to leonschwanitz/next-auth that referenced this issue Jun 12, 2023
@leonschwanitz
Update github.md
0b30aa5 
nextauthjs#7777
@leonschwanitz leonschwanitz mentioned this issue Jun 12, 2023
Merged
3 tasks
balazsorban44 added a commit that referenced this issue Jan 23, 2024
@leonschwanitz @balazsorban44
docs: update github.md app permissions (#7778)
9296222 
* Update github.md

#7777

* Apply suggestions from code review

---------

Co-authored-by: Balázs Orbán <info@balazsorban.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leonschwanitz