Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): separately export AdapterAccountType #10832

Merged
merged 2 commits into from
May 6, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented May 6, 2024

☕️ Reasoning

  • Separately export AdapterAccountType to avoid circular references when using AdapterAccount to define one's own schemas, i.e. with Drizzle and Prisma custom schemas
  • Ex: https://tsplay.dev/mpG8gN

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@ndom91 ndom91 requested a review from ThangHuuVu as a code owner May 6, 2024 12:33
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 0:43am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:43am
proxy ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 0:43am

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` labels May 6, 2024
Copy link
Contributor

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ndom91 ndom91 changed the title fix(types): separately export AdapterAccountType chore(types): separately export AdapterAccountType May 6, 2024
@ndom91 ndom91 merged commit bfa7079 into main May 6, 2024
9 of 10 checks passed
@ndom91 ndom91 deleted the ndom91/export-adapteraccounttype-separately branch May 6, 2024 12:36
hillac pushed a commit to hillac/next-auth that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants