Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typeorm): cleanup adapter testing files #10833

Merged
merged 5 commits into from
May 9, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented May 6, 2024

☕️ Reasoning

  • Cleanup TypeORM test files to match the setup of the other adapters.
  • Each DB Type has a test.sh file which:
    • (1) sets up the DB container (if necessary)
    • (2) Runs the vitest cmd and exists if failed
    • (3) Cleans up
    • These were previously tangled up together in the pre-existing test.sh scripts, so that it was impossible to just run somethign like a test script for 1 specific adapter (i.e. test:sqlite)
  • Small cleanup in drizzle sqlite test file, was running the tests twice and specifying the node option to --import tsx, although we're now using tsx to run the .ts files already, not node

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@ndom91 ndom91 requested a review from ubbe-xyz as a code owner May 6, 2024 13:19
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 10:35am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 10:35am
proxy ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 10:35am

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters typeorm @auth/typeorm-adapter drizzle @auth/drizzle-adapter labels May 6, 2024
@ndom91 ndom91 changed the title fix: drizzle rm redundant sqlite vitest run chore(typeorm): cleanup adapter testing files May 6, 2024
Copy link

socket-security bot commented May 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@actions/github@6.0.0 environment, filesystem Transitive: network, unsafe +17 8.12 MB thboop
npm/@radix-ui/react-avatar@1.0.4 None +6 410 kB benoitgrelard
npm/@radix-ui/react-collapsible@1.0.3 None +11 504 kB benoitgrelard
npm/@radix-ui/react-dropdown-menu@2.0.6 Transitive: environment +41 2.26 MB benoitgrelard
npm/@radix-ui/react-navigation-menu@1.1.4 None +17 909 kB benoitgrelard
npm/@radix-ui/react-slot@1.0.2 None +3 328 kB benoitgrelard
npm/@sveltejs/adapter-auto@3.2.0 environment +1 84.2 kB svelte-admin
npm/@sveltejs/kit@2.5.7 environment, eval Transitive: filesystem +15 1.47 MB svelte-admin
npm/@sveltejs/vite-plugin-svelte@3.1.0 Transitive: environment +8 798 kB svelte-admin
npm/@types/express@4.17.21 None +9 107 kB types
npm/@types/morgan@1.9.9 None 0 13.9 kB types
npm/@types/node@18.19.30 None +1 2.04 MB types
npm/@types/node@20.11.15 None 0 3.99 MB types
npm/@types/node@20.12.7 None 0 2.03 MB types
npm/@types/react-dom@18.2.24 None 0 34.9 kB types
npm/@types/react@18.2.74 None +2 1.68 MB types
npm/autoprefixer@10.4.19 environment Transitive: filesystem, shell +10 2.77 MB ai
npm/broken-link-checker@0.7.8 network Transitive: environment, eval, filesystem, shell, unsafe +133 9.62 MB stevenvachon
npm/class-variance-authority@0.7.0 None +1 15.7 kB joebell93
npm/clsx@2.1.0 None 0 8.46 kB lukeed
npm/express@4.19.2 environment, filesystem, network Transitive: eval, unsafe +59 2.05 MB wesleytodd
npm/lucide-react@0.274.0 None 0 19.6 MB ericfennis
npm/morgan@1.10.0 eval Transitive: environment, filesystem, network +8 181 kB dougwilson
npm/next@14.1.4 environment, filesystem, network, shell, unsafe +13 90.3 MB vercel-release-bot
npm/postcss@8.4.38 environment, filesystem +3 368 kB ai
npm/pug@3.0.2 environment, eval, filesystem +43 6.46 MB pug-bot
npm/react-dom@18.2.0 environment +3 4.62 MB gnoff
npm/react@18.2.0 environment +2 337 kB gnoff
npm/svelte-check@3.6.9 Transitive: environment, eval, filesystem, unsafe +31 10.5 MB svelte-language-tools-deploy
npm/svelte@4.2.15 Transitive: unsafe +17 6.31 MB svelte-admin
npm/tailwind-merge@1.14.0 environment 0 765 kB dcas
npm/tailwindcss-animate@1.0.7 None 0 18.1 kB thejameskyle
npm/tailwindcss@3.4.3 environment, filesystem Transitive: network, shell, unsafe +100 14.1 MB adamwathan
npm/tsup@8.0.1 environment, eval, filesystem Transitive: shell, unsafe +40 6.34 MB egoist
npm/tsx@4.7.0 Transitive: filesystem, unsafe +1 495 kB hirokiosame
npm/tsx@4.7.3 Transitive: environment, filesystem, network, shell, unsafe +3 630 kB hirokiosame
npm/typescript@5.3.3 None 0 32 MB typescript-bot
npm/typescript@5.4.4 None 0 32.4 MB typescript-bot
npm/typescript@5.4.5 None 0 32.4 MB typescript-bot
npm/vite@5.2.10 environment, eval, filesystem, network, shell, unsafe +3 6.01 MB vitebot

🚮 Removed packages: npm/@ariakit/react@0.4.5, npm/@auth/prisma-adapter@2.0.0, npm/@auth/unstorage-adapter@2.0.0, npm/@aws-sdk/client-dynamodb@3.499.0, npm/@aws-sdk/lib-dynamodb@3.499.0, npm/@azure/data-tables@13.2.2, npm/@balazsorban/monorepo-release@0.5.1, npm/@cloudflare/workers-types@4.20240117.0, npm/utils@0.0.0

View full report↗︎

Copy link

socket-security bot commented May 6, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/svelte-preprocess@5.1.3
  • Install script: postinstall
  • Source: echo "[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc..."
Telemetry npm/next@14.1.4
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information
Install scripts npm/@sveltejs/kit@2.5.7
  • Install script: postinstall
  • Source: node postinstall.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/svelte-preprocess@5.1.3
  • @SocketSecurity ignore npm/next@14.1.4
  • @SocketSecurity ignore npm/@sveltejs/kit@2.5.7

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.97%. Comparing base (8751fa4) to head (5ff6317).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10833   +/-   ##
=======================================
  Coverage   37.97%   37.97%           
=======================================
  Files         173      173           
  Lines       27238    27238           
  Branches     1174     1174           
=======================================
  Hits        10343    10343           
  Misses      16895    16895           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 merged commit 5136b3f into main May 9, 2024
13 of 15 checks passed
@ndom91 ndom91 deleted the ndom91/cleanup-typeorm-tests branch May 9, 2024 10:37
hillac pushed a commit to hillac/next-auth that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters drizzle @auth/drizzle-adapter typeorm @auth/typeorm-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant