-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(next-auth): allow react@19 to peer deps #10882
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@devjiwonchoi is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
@@ -84,7 +84,7 @@ | |||
"@simplewebauthn/server": "^9.0.2", | |||
"next": "^14", | |||
"nodemailer": "^6.6.5", | |||
"react": "^18.2.0" | |||
"react": "^18.2.0 || ^19.0.0-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should cover more 19.x
things for now and in the future
"react": "^18.2.0 || ^19.0.0-0" | |
"react": "^18.2.0 || ^19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK caret-only ^
doesn't cover the pre-release as well, it had to be set explicitly with -
.
x-ref: https://semver.npmjs.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, makes sense. Thanks for the npm semver calc link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing!
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@auth/unstorage-adapter@2.1.0, npm/@types/react-dom@18.3.0, npm/@types/react@18.3.2, npm/autoprefixer@10.4.19, npm/class-variance-authority@0.7.0, npm/clsx@2.1.1, npm/lucide-react@0.274.0, npm/next-auth@5.0.0-beta.18, npm/next@14.2.3 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10882 +/- ##
=======================================
Coverage 38.39% 38.39%
=======================================
Files 176 176
Lines 27454 27454
Branches 1212 1212
=======================================
Hits 10541 10541
Misses 16913 16913 ☔ View full report in Codecov by Sentry. |
chore: add react peer deps 19 Co-authored-by: Nico Domino <yo@ndo.dev>
☕️ Reasoning
next@canary
peerDeps have React19, so add them.🧢 Checklist
🎫 Affected issues
📌 Resources