chore: normalize AuthError message
#10964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
@k-taro56 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
k-taro56
changed the title
AuthError messageAuthError message
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10964 +/- ##
==========================================
- Coverage 39.92% 39.92% -0.01%
==========================================
Files 179 179
Lines 28671 28669 -2
Branches 1243 1249 +6
==========================================
- Hits 11446 11445 -1
+ Misses 17225 17224 -1 ☔ View full report in Codecov by Sentry. |
ThangHuuVu
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Messages passed to the constructor of a class that extends
AuthErrormust not end with a period'.'.Ending with a period
'.'causes the constructor to normalize and add a double period'..'.next-auth/packages/core/src/errors.ts
Line 76 in b420d36
I have checked that other error messages do not end with a period.
🧢 Checklist
🎫 Affected issues
No Issue
📌 Resources