Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: normalize AuthError message #10964

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

k-taro56
Copy link
Contributor

@k-taro56 k-taro56 commented May 19, 2024

☕️ Reasoning

Messages passed to the constructor of a class that extends AuthError must not end with a period '.'.
Ending with a period '.' causes the constructor to normalize and add a double period '..'.

this.message += `${this.message ? ". " : ""}Read more at ${url}`

I have checked that other error messages do not end with a period.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

No Issue

📌 Resources

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 2:46pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 14, 2024 2:46pm

Copy link

vercel bot commented May 19, 2024

@k-taro56 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added providers core Refers to `@auth/core` labels May 19, 2024
@k-taro56 k-taro56 changed the title normalize AuthError message chore: normalize AuthError message May 19, 2024
Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 40.10%. Comparing base (d38fdef) to head (1fef09d).

Files Patch % Lines
...ages/core/src/lib/actions/callback/oauth/checks.ts 20.00% 8 Missing ⚠️
packages/core/src/lib/utils/assert.ts 50.00% 4 Missing ⚠️
packages/core/src/providers/webauthn.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10964      +/-   ##
==========================================
- Coverage   40.10%   40.10%   -0.01%     
==========================================
  Files         178      178              
  Lines       28527    28525       -2     
  Branches     1240     1246       +6     
==========================================
- Hits        11440    11439       -1     
+ Misses      17087    17086       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vercel vercel bot temporarily deployed to Preview – auth-docs June 14, 2024 10:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant