fix: Use sub instead of id in Gitlab #11176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://docs.gitlab.com/ee/integration/openid_connect_provider.html The profile id is in the `sub` field not in the `id` field
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@tedzards509 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
When sub.toString() is called on an undefined sub, this prevents it from reaching the error handler for a non-existing id field leading to a more cryptic error. Hence the addition of the ? |
balazsorban44
requested changes
Jul 2, 2024
There was a problem hiding this comment.
I saw your comment, but based on the linked documentation, sub should never be undefined and is already of type string @tedzards509. Can you verify this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.gitlab.com/ee/integration/openid_connect_provider.html
The profile id is in the
subfield not in theidfield☕️ Reasoning
https://docs.gitlab.com/ee/integration/openid_connect_provider.html
According to this documentation for Gitlab as an OIDC provider, "The ID of the user" is in the
subfield. Anidfield is not provided. This change works with Gitlab Enterprise version 16.11 while editing nect-auth version 4.24.5 due to other issues that were fixed by downgrading.🧢 Checklist
🎫 Affected issues
📌 Resources