Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more clearly document reproduction link requirements #11226

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

benmccann
Copy link
Contributor

☕️ Reasoning

  • change may to will. may indicates some human reasoning where there is none
  • clarify that the reproduction must be hosted on github.com. it's very common to use stackblitz and some issues are better explained with something like publint.dev. let users know that these seemingly valid reproductions aren't accepted
  • the overall PR template description is one character shorter now. the comment that the bot responds with is longer, but more precise and we're not as space constrained there

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes #11181

📌 Resources

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 5:04pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 5:04pm

Copy link

vercel bot commented Jun 21, 2024

@benmccann is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Since we used nissuer, issues are automatically closed so this definitely helps to adjust the expectation.

@ThangHuuVu ThangHuuVu merged commit 071b0a3 into nextauthjs:main Jun 21, 2024
11 of 13 checks passed
@benmccann benmccann deleted the bot-docs branch June 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear what GitHub bot considers to be a valid reproduction
2 participants