Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apple provider checks should be ['state', 'nonce'] #11239

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

promer94
Copy link
Contributor

☕️ Reasoning

This pr changes apple proivder checks config to ['state', 'nonce'] to align with apple's doc

🧢 Checklist

  • Ready to be merged

Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 11:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 11:05am

Copy link

vercel bot commented Jun 23, 2024

@promer94 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.91%. Comparing base (d00d913) to head (996d13c).

Files Patch % Lines
packages/core/src/providers/apple.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11239      +/-   ##
==========================================
- Coverage   39.92%   39.91%   -0.01%     
==========================================
  Files         179      179              
  Lines       28671    28673       +2     
  Branches     1249     1249              
==========================================
  Hits        11446    11446              
- Misses      17225    17227       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balazsorban44 balazsorban44 merged commit 8ea51aa into nextauthjs:main Jul 2, 2024
12 of 15 checks passed
@promer94 promer94 deleted the fix-apple-check-config branch July 3, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants