Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drizzle): update schemas & refactor #11409

Open
wants to merge 72 commits into
base: main
Choose a base branch
from

Conversation

realmikesolo
Copy link
Contributor

I have updated schemas and types with email being nullable in users table. Also, I have bumped Drizzle ORM & Drizzle Kit versions and refactored tests.

☕️ Reasoning

As already discussed in discord channel, email column should be nullable.

realmikesolo and others added 30 commits April 2, 2024 14:38
We would like to have feature parity of Auth.js when hosted either on something like Vercel or in Docker. Moving the docker config to the same example app we host on Vercel and deploying it via Docker will make this easier to verify
…0504)

Update README.md fixed .cts to .cjs

Co-authored-by: Nico Domino <yo@ndo.dev>
@realmikesolo realmikesolo marked this pull request as ready for review July 20, 2024 17:07
Copy link

socket-security bot commented Jul 20, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@realmikesolo
Copy link
Contributor Author

I have added id to fixtures because NextAuth always pass value for id, so I think it should be in fixtures to provide correct test cases.

@ndom91
Copy link
Member

ndom91 commented Jul 21, 2024

@realmikesolo it looks like the pnpm-lock.yaml is from a much older commit. By just bumping two versions we shuoldn't get ~30k changed lines 😅 Would be great if you could fix that.

Maybe git checkout pnpm-lock.yaml origin/main to get the latest version fo that file from main, then run pnpm install again to update it with your bumped drizzle versions, and thennn you should have a normal up-to-date pnpm-lock.yaml to commit 🙏

@realmikesolo
Copy link
Contributor Author

Hello @ndom91! I have fixed pnpm-lock.yaml

@ndom91
Copy link
Member

ndom91 commented Jul 25, 2024

Nice, looks much better!

Out of curiosity, do the non-PK columns really all need that isPrimaryKey: false? 🤔

@realmikesolo
Copy link
Contributor Author

Hey @ndom91. I have updated type, so if we don't need isPrimaryKey: false for non-PK columns. But I have faced this issue Cannot find module '@auth/core/adapters' or its corresponding type declarations and it is a bit strange for me because I didn't change any dependencies related to auth/core. Could you please check it?

@ndom91
Copy link
Member

ndom91 commented Jul 25, 2024

Hey @ndom91. I have updated type, so if we don't need isPrimaryKey: false for non-PK columns. But I have faced this issue Cannot find module '@auth/core/adapters' or its corresponding type declarations and it is a bit strange for me because I didn't change any dependencies related to auth/core. Could you please check it?

Yeah I don't have time today, but this weekend I can definitely take a closer look and hopefully get this merged. The lock file definitely looks much better!

@realmikesolo
Copy link
Contributor Author

Hey @ndom91. I have updated type, so if we don't need isPrimaryKey: false for non-PK columns. But I have faced this issue Cannot find module '@auth/core/adapters' or its corresponding type declarations and it is a bit strange for me because I didn't change any dependencies related to auth/core. Could you please check it?

Yeah I don't have time today, but this weekend I can definitely take a closer look and hopefully get this merged. The lock file definitely looks much better!

Ok, thank you very much!

@ndom91
Copy link
Member

ndom91 commented Jul 27, 2024

Hey @ndom91. I have updated type, so if we don't need isPrimaryKey: false for non-PK columns. But I have faced this issue Cannot find module '@auth/core/adapters' or its corresponding type declarations and it is a bit strange for me because I didn't change any dependencies related to auth/core. Could you please check it?

Where are you running into this @auth/core/adapters issue? I was abel to run all the tests successfully still

@realmikesolo
Copy link
Contributor Author

Hey @ndom91. I have updated type, so if we don't need isPrimaryKey: false for non-PK columns. But I have faced this issue Cannot find module '@auth/core/adapters' or its corresponding type declarations and it is a bit strange for me because I didn't change any dependencies related to auth/core. Could you please check it?

Where are you running into this @auth/core/adapters issue? I was abel to run all the tests successfully still

I was facing this issue during the build. It might be problem on my local setup then. Thank you for your time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters drizzle @auth/drizzle-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants