fix(client): reload after login/logout when url contains hash #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/9h9hzoev1 |
3 tasks
balazsorban44
changed the title
|
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Reload the page after
signInorsignOutis called, even if the URL contains a hash.Why:
A small experiment:
window.location = "https://google.com#top"Observe that "nothing" happens.
We use
window.location =to reload the page after a successful login/logout, but it does not work in the above mentioned case.How:
After
window.locationis set, check if the url contains a#, if it does, reload the page withwindow.location.reload()Checklist:
- [ ] DocumentationThis has been discovered in #1107 by @ThewBear, so the credit goes to them!
I re-created the PR, because we did some changes in our release process and unfortunately all open PRs are getting massive merge conflicts now. Since it was a small update, I did not wish to ask the original creator to fix all those issues. (Very sorry for the inconvenience! 🙏)
Fixes #532