Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(provider): Update IdentityServer 4 demo configuration #1932

Merged
merged 1 commit into from May 5, 2021
Merged

Conversation

Thisen
Copy link
Contributor

@Thisen Thisen commented May 5, 2021

Reasoning 💡

The currently documented demo configuration with the demo IdentityServer 4 doesn't work. I've updated the configuration, so it works.

I also ran Prettier on the file, causing some whitespace changes.

Checklist 🧢

  • Documentation
  • Ready to be merged

@vercel
Copy link

vercel bot commented May 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/7WeEEov9Xw2yL8awkyHdsz6uvfrC
✅ Preview: https://next-auth-git-fork-thisen-main-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview May 5, 2021 09:32 Inactive
@github-actions github-actions bot added the documentation Relates to documentation label May 5, 2021
@Thisen Thisen changed the title Update IdentityServer 4 demo configuration docs(providers): Update IdentityServer 4 demo configuration May 5, 2021
@balazsorban44 balazsorban44 changed the title docs(providers): Update IdentityServer 4 demo configuration docs(provider): Update IdentityServer 4 demo configuration May 5, 2021
@balazsorban44 balazsorban44 merged commit 2fce08c into nextauthjs:main May 5, 2021
balazsorban44 added a commit that referenced this pull request May 6, 2021
* Constrain the adapters type generics more accurately

* Add types for the incoming messages to events callbacks

* Code review comments from @lluia

* Rebase from trunk and fix merge conflicts

* Update documentation

* Rip out generics

* fix(build): export aliases from client (#1909)

* docs(provider): update providers documentation (#1900)

* docs(providers): update providers documentation

- delineate clearly the 3 provider types (oauth, email, credentials)
- make each section structure consistent
- update the option list for every provider type
- use emojis

* docs(providers): instructions on new provider types

* docs(providers): remove emojis

To stay consistent with the rest of our documentation, for now we should not emojis on the sections of our documentation pages.

* docs(providers): reword sentence

Co-authored-by: Balázs Orbán <info@balazsorban.com>

* docs(providers): add tip on overriding options

* docs(providers): clarify `params` option usage

* docs(providers): make names list inline

Co-authored-by: Balázs Orbán <info@balazsorban.com>

* fix(ts): unset generics defaults for overriding (#1891)

Co-authored-by: Lluis Agusti <hi@llu.lu>

* fix(ts): tweak Adapter related types (#1914)

Contains the following squashed commits:

* fix(ts): make first adapter parameter non-optional
* fix(ts): make defaulted values non-optional internally
* test(ts): fix linting

* fix(page): don't pass params to custom signout page (#1912)

* For the custom signout page addressed two issues with the query params being added to the signout url. A conditional check on the error value is now made before adding it as a query param. Also added a conditional check on the callbackUrl and if present that then gets appended as a query param to the signout api call.

* Changed fix for bug #192 to have no querystring params in the custom signout page url.

Co-authored-by: anubisoft <anubisoftprez@gmail.com>
Co-authored-by: Lluis Agusti <hi@llu.lu>

* docs(www): fix typo (#1922)

* docs(provider): Update IdentityServer 4 demo configuration (#1932)

* Responding to code review comments

* Fix tests

* Fix lint error

Co-authored-by: Lluis Agusti <hi@llu.lu>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Co-authored-by: Kristóf Poduszló <kripod@protonmail.com>
Co-authored-by: Anubisoft <1471887+anubisoft@users.noreply.github.com>
Co-authored-by: anubisoft <anubisoftprez@gmail.com>
Co-authored-by: Ernie Miranda <emiranda04@users.noreply.github.com>
Co-authored-by: Mathis Møller <thisen-dk@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants