Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Convert Github profile.id from int to string #2108

Merged
merged 1 commit into from Jun 9, 2021
Merged

Fix: Convert Github profile.id from int to string #2108

merged 1 commit into from Jun 9, 2021

Conversation

tom-richter
Copy link
Contributor

@tom-richter tom-richter commented Jun 1, 2021

Reasoning 💡

This Github profile.id should be converted from integer to string as described here: https://github.com/nextauthjs/adapters/issues/111. We should check if other adapters/functions still rely on profile.id being an integer.

BREAKING CHANGE:

For consistency around our built-in providers, the profile id is now converted to a string. If you had assumptions about the id being a number, you can do parseInt(profile.id, 10)

@vercel
Copy link

vercel bot commented Jun 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/8Tj6KL1YDzQ3oeRjoAQ9ZjYY3Z8z
✅ Preview: https://next-auth-git-fork-tom-richter-main-nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview June 1, 2021 07:29 Inactive
@github-actions github-actions bot added core Refers to `@auth/core` providers labels Jun 1, 2021
@balazsorban44
Copy link
Member

Yeah.. 😕 I am a bit afraid that it might cause problems for people who currently expect this to be an integer actually. 😨 We might just want to hold onto this PR until v4.0 and you can use your workaround locally until then?

If it only were TS, I wouldn't mind, but here we actually change the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants