-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adapters): Add Supabase adapter #5050
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
So first of all, thanks for the PR! Especially the thorough docs, readme, pr template update, etc! 🎉 A few questions though:
Thanks again! |
Also just fyi in case you didn't see, @balazsorban44 had previously worked on a Supabase adapter (nextauthjs/adapters#188) but the PR was never merged. |
@ndom91 Thanks for your feedback! Sorry for the delay but here are some answers:
Correct, I've read the discussion and think that @chanceaclark's comment pretty much applies here as well. If you want however, I could take a look at Supabase Auth again and see what's possible/makes sense.
I've disabled email and Apple auth services now, the others seem to be required by the CLI.
Thanks, I forgot about that. I made some changes and removed access for the |
Hey no worries! So first off, no just using the supabase postgres as an adapter here is perfect! Don't worry about the supabase auth stuff. Otherwise, thanks for fixing up those other minor comments! I'll take another look at this shortly, but should be more or less good to go then 🥳 |
Any updates on this one? |
@balazsorban44 @ThangHuuVu what do you think? This looks good to go to me 👍 |
@balazsorban44 @ThangHuuVu Is there any update for that? |
what's the hold up here? |
It would be so nice if this one is getting merged 💪 |
Bumping this PR up. Looks amazing! |
Bumping this pr |
@lluia @ndom91 @balazsorban44 @ThangHuuVu, Could you guys review this PR and approve it? Thanks! |
Adding another bump. |
@thorwebdev is attempting to deploy a commit to the NextAuth Team on Vercel. A member of the Team first needs to authorize it. |
@ndom91 @balazsorban44 I've built on top of @msonnberger awesome work to document how to do RLS with NextAuth & Supabase 🥳 The main changes:
Let me know if you have any questions or concerns with any of this! |
bumping up this pr |
This comment was marked as resolved.
This comment was marked as resolved.
Any updates? |
Could anyone check this PR? |
The PR has been thoroughly tested and is ready for review and merge 👍 |
Does this adapter use the default Auth schema of Supabase or does it create a separate schema? |
Hi @ndom91, apologies, as I'm not sure what the process for having this approved is, but do you know if someone could have a look at this and ok it? I'd love to be able to implement this over the coming weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of comments regarding unique constraints, let me know what you think! Thanks everyone for the PR, let's get this merged soon 🙌
packages/adapter-supabase/supabase/migrations/20221108043803_create_next_auth_schema.sql
Outdated
Show resolved
Hide resolved
packages/adapter-supabase/supabase/migrations/20221108043803_create_next_auth_schema.sql
Show resolved
Hide resolved
@ThangHuuVu thanks for the review. I went through the prisma schema and the sequelize model (FYI, they aren't identical) but I think I now picked everything from across them. PTAL :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
☕️ Reasoning
This PR adds an adapter for Supabase.
🧢 Checklist