fix(firebase): add ability to pass in firebase config #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
adapters
|
cc. @balazsorban44 |
|
@chanceaclark @balazsorban44 @ndom91 @lluia Sorry for pinging you all but will we have approval soon? |
balazsorban44
force-pushed
the
main
branch
6 times, most recently
from
19c6807
to
3be7bb7
Compare
3 tasks
notrab
pushed a commit
to notrab/next-auth
that referenced
this pull request
Feb 22, 2023
…hjs#6225) Co-authored-by: Balázs Orbán <info@balazsorban.com> fixes nextauthjs#5049 closes nextauthjs#6230 closes nextauthjs#5449 closes nextauthjs#5055 fixes nextauthjs#4927 BREAKING CHANGE: The adapter now expects `firebase-admin` instead of the `firebase` package and also supports either passing a config object or a firestore instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Adds the ability to pass in Firebase config into the adapter to initialize the app, rather than initializing by default. This is useful if you've initialized the app on the client and want to reuse the config on the server. Alongside that, adds some documentation on how to use it.
Note: Ran
prettier --write packages/adapter-firebasewhich cleaned up some files.🧢 Checklist
🎫 Affected issues
Fixes: #4927
📌 Resources