-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Microsoft SQL Server #514
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/fqmzzk6m5 |
As per Ms docs, snake_case should be the choice. But I know by experience that is very common to use TitleCase, due it's strong connection to the .Net framework , c#, entity-framework, LinkToSql, Dapper, etc... due to tie to the POCOS (plain c# objects) m, Dtos or whatever you want to call them :). Nevertheless I've seen Hungarian notation like naming everywhere too :( Personally, I'll prefer names that can be mapped straight to the naming convention of language you are working on, just in case you need to 'raw query'. And again that might not be a problem with next-auth, or typeorm, as there is no need to have the models named exactly as they were typed on the database (correct me if wrong). IMMO as far you can change it to suit you needs it's all good. :) ... sorry it got a bit long |
@D10221 Thank you for the quick response, that's a really complete answer and I appreciate it! I'm not familiar with mssql culture / conventions so wanted to avoid us doing something unconventional by default. |
9e86517
to
f2e90bd
Compare
9edf3b6
to
88668d2
Compare
Testing out the new Microsoft SQL Server support added by @D10221
I propose we release this as v3.1 - along with the Basecamp provider PR in #511 and the support for entity hot reloading in #488, unless there are any objections or any other features or changes people would like to see make the cut?
Thanks again @D10221!