fix(mikro-orm): re-enable tests #5316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
adapters
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
from
2757d33
to
4d71f81
Compare
boredland
changed the title
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
from
6751a6c
to
3738674
Compare
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
from
513cce1
to
24574e0
Compare
boredland
requested review from
balazsorban44
and removed request for
ubbe-xyz and
ndom91
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
2 times, most recently
from
d0ef0ca
to
a87b9db
Compare
This comment was marked as outdated.
This comment was marked as outdated.
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
2 times, most recently
from
44a3271
to
64bd3b6
Compare
|
@balazsorban44 as we previously had a broken schema that was unusable for sso providers as I see it, we should make this a breaking change - users will need to run a migration that updates fields to their new types. |
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
5 times, most recently
from
b47141a
to
e74105a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ThangHuuVu
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
I skimmed the PR, it looks pretty good to me. Before we merge it, I'd like t ask for @ndom91's review
|
Is there anything I can do to speed this up? |
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
2 times, most recently
from
b32e590
to
3627e89
Compare
|
@ndom91 and @balazsorban44 should I rebase this? don't want it to go stale again... |
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
2 times, most recently
from
a5726a7
to
1b60daa
Compare
While I have a working setup for tests with swc using 'next/jest', I struggle getting a working setup here. So I installed ts-jest and some missing peer dependencies.
BREAKING CHANGE: apparently oauth providers were not working previously, as two important fields had the wrong types. this change will require users to run an appropriate migration. closes nextauthjs#5286
BREAKING CHANGE in mikro-orm prior to 4.2 collections emit a type `Collection<Session, unknown>` this makes them essentially incompatible (read: unextendable) by the newest mikro-orm versions. In newer versions this always should be `Collection<Session, object>`, hence enforcing this for older mikro- orm versions.
boredland
force-pushed
the
chore/enable-mikro-orm-tests
branch
from
1b60daa
to
f2b2c65
Compare
|
added another fix on top and updated some versions. perhaps you could have another look @ThangHuuVu ? |
|
Yeah this also looks good to me! Just approved another round of CI to double check the tests pass 👍 |
|
Cool, thank you @boredland @ndom91, merging it now 🙌 |
balazsorban44
added a commit
that referenced
this pull request
Sep 25, 2022
BREAKING CHANGE: See #5316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swc/jest and decorators seems to be a hard nut to crack. But probably having reflection based metadata on our schema (and thus putting assumptions on the users setup) has not been a good idea to begin with. So I decided to follow the approach in an upstream PR and inserted reflection-less meta-data everywhere.
☕️ Reasoning
Aims to re-enable the tests, as I'd like to make some changes and need working regression tests.
closes #5286 as a side-effect.
🧢 Checklist