Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapters): add Kysely adapter #5464

Merged
merged 43 commits into from
Aug 8, 2023

Conversation

mwojtul
Copy link
Contributor

@mwojtul mwojtul commented Oct 1, 2022

☕️ Reasoning

Kysely is a really nice new type safe query builder and it'd be cool to have an adapter for it.

The adapter supports the built in SQL dialects that Kysely supports (PostgreSQL, MySQL, and SQLite). Kysely itself doesn't have any ORM functionality, so I tried to write the adapter methods in a sane way while supporting all three dialects and avoiding creating a mini ORM. The test suite is being run for all three dialects.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Closes #4922.

📌 Resources

@vercel
Copy link

vercel bot commented Oct 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2023 10:51pm
next-auth ✅ Ready (Inspect) Visit Preview Aug 8, 2023 10:51pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
auth-docs-nextra ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2023 10:51pm
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2023 10:51pm

@github-actions github-actions bot added the adapters Changes related to the core code concerning database adapters label Oct 1, 2022
@vercel vercel bot temporarily deployed to Preview October 1, 2022 09:08 Inactive
packages/adapter-kysely/tests/index.test.ts Dismissed Show dismissed Hide dismissed
packages/adapter-kysely/tests/index.test.ts Dismissed Show dismissed Hide dismissed
packages/adapter-kysely/tests/index.test.ts Dismissed Show dismissed Hide dismissed
@vercel vercel bot temporarily deployed to Preview October 1, 2022 21:31 Inactive
@vercel vercel bot temporarily deployed to Preview October 2, 2022 07:17 Inactive
Co-authored-by: Lars Graubner <lgraubner@users.noreply.github.com>
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work on this! I added some of my changes, but this looks good to be released!

I appreciate the time you've spent on this PR and apologies for the long waiting...

@balazsorban44 balazsorban44 merged commit 1eddcf6 into nextauthjs:main Aug 8, 2023
11 of 12 checks passed
@balazsorban44
Copy link
Member

This is now released! @auth/kysely-adapter@0.1.0 Thanks for everyone's patience on this. 🙏 💚 Let us know!

@mwojtul
Copy link
Contributor Author

mwojtul commented Aug 9, 2023

@balazsorban44 thanks for taking it across the finish line 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter: add kysely adapter
8 participants