fix: add getSetCookie to session cookies if supported #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
@edenstrom is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
viktorlarsson
approved these changes
Sep 18, 2023
|
Closed due to not currently working.. Fixing. |
|
hey @edenstrom are you still working on a fix for this? |
Yes, reopened PR with fix. :) Works here. https://next-auth-error-vercel.vercel.app/ |
|
You're a lifesaver 🔥 |
|
Could we get this merged? |
balazsorban44
approved these changes
Sep 29, 2023
balazsorban44
merged commit f2c23db
into
nextauthjs:feat/nextjs-auth
12 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
I saw that .getSetCookie were finally supported in the edge runtime when deployed to Vercel. This uses
getSetCookieif supported, otherwise falls back to.get('set-cookie)Deployed a version with this patch here:
Reproduction deployment: next-auth-error-vercel.vercel.app
Reproduction repo: edenstrom/next-auth-error-vercel
🧢 Checklist
🎫 Affected issues
This solves the long standing issue were chunked cookies didn't work when using the edge runtime deployed to Vercel.
#7443 (comment)
Related issues:
fetchvercel/edge-runtime#536📌 Resources