Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Reddit Authentication #866

Merged
merged 4 commits into from
Dec 6, 2020
Merged

Fix for Reddit Authentication #866

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d1ae87
Fixed Reddit Authentication
afoyer Nov 20, 2020
77e8266
updated fix for build test
afoyer Nov 20, 2020
b438809
updated buffer to avoid deprecation message
afoyer Nov 20, 2020
1c05293
Updated for passing tests
afoyer Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/server/lib/oauth/callback.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,12 @@ async function _getOAuthAccessToken (code, provider, callback) {
if (!params.redirect_uri) { params.redirect_uri = provider.callbackUrl }

if (!headers['Content-Type']) { headers['Content-Type'] = 'application/x-www-form-urlencoded' }

// Added as a fix to accomodate change in Twitch oAuth API
if (!headers['Client-ID']) { headers['Client-ID'] = provider.clientId }

// Added as a fix for Reddit Authentication
if (provider.id === 'reddit') {
headers.Authorization = 'Basic ' + Buffer.from((provider.clientId + ':' + provider.clientSecret)).toString('base64')
}
// Okta errors when this is set. Maybe there are other Providers that also wont like this.
if (setGetAccessTokenAuthHeader) {
if (!headers.Authorization) { headers.Authorization = `Bearer ${code}` }
Expand Down