Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prisma): support webauthn #9876

Merged
merged 4 commits into from Feb 5, 2024

Conversation

Maronato
Copy link
Contributor

@Maronato Maronato commented Feb 2, 2024

☕️ Reasoning

Sibling PR to #8808 that implements:

  • WebAuthn adapter tests
  • WebAuthn methods for the Prisma adapter
  • Fixes schema issues in surrealdb and hasura adapters

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Feb 5, 2024 9:09pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 9:09pm

Copy link

vercel bot commented Feb 2, 2024

@Maronato is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters prisma @auth/prisma-adapter hasura surrealdb labels Feb 2, 2024
@ndom91
Copy link
Member

ndom91 commented Feb 2, 2024

Fixes schema issues in surrealdb and hasura adapters

Is this required? If not, I'd maybe just drop this so this is a clean prisma-only implementation for webauthn support.

Otherwise LGTM though!

@Maronato
Copy link
Contributor Author

Maronato commented Feb 3, 2024

Is this required?
Hasura and SurrealDB refuse to build otherwise

@ndom91 ndom91 changed the title WebAuthn adapter Tests / migrations feat(prisma): add webauthn adapter methods and tests Feb 5, 2024
@ndom91 ndom91 changed the title feat(prisma): add webauthn adapter methods and tests feat(prisma): support webauthn Feb 5, 2024
@ndom91 ndom91 merged commit b2705f2 into nextauthjs:main Feb 5, 2024
5 of 7 checks passed
balazsorban44 pushed a commit that referenced this pull request Feb 5, 2024
passkey adapter stuff

Co-authored-by: Nico Domino <yo@ndo.dev>
ndom91 added a commit that referenced this pull request Feb 5, 2024
* Fixed typos in supabase documentation (#9698)

chore: Fix typos in supabase adapter documentation

* initial passkeys

* working v1

* cleanup

* remove GetUserInfo restraints

* fix webpack renaming issues

* Use simplewebauthn server 9.0.1

* disconnect webauthn userID and internal database userID

* Add webauthn method testing to adapter utils

* move simplewebauthn/server to peerdeps

* update pnpm lock

* comment improvements

* use User instead of AdapterUser for webauthn methods

* remove unnecessary casting

* rename baseURL to authURL in webauthn contexts

* use inferWebAuthnOptions instead of decideWebAuthnOptions

* fix inferWebAuthnOptions docstring

* remove unecessary default value in inferWebAuthnOptions

* infer relaying party from request url

* simplify getLoggedInUser

* validate provider.simpleWebAuthnBrowserVersion in assertConfig

* add tests to webauthn-utils

* allow multiple relaying parties

* remove changes to dev app

* fix email and db session assertion

* move adapter codebase to new PR

* fix adapter builds

* fix: move @simplewebauthn/browser to peerDep

* fix: add note about installing peerDep to passkeys provider docs page

* fix: dynamic import webauthn browser methods

* fix: move webauthn signin to own export

* feat(prisma): support webauthn (#9876)

passkey adapter stuff

Co-authored-by: Nico Domino <yo@ndo.dev>

---------

Co-authored-by: Vishal Kashi <dev.vishalkashi@gmail.com>
Co-authored-by: Nico Domino <yo@ndo.dev>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters hasura prisma @auth/prisma-adapter surrealdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants