Merge pull request #927 from nextcloud-libraries/fix/missing-defaults

nextcloud-libraries · Aug 23, 2023 · c25014d · c25014d
2 parents 01722ce + da39d28
commit c25014d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/components/DialogButton.vue b/lib/components/DialogButton.vue
@@ -14,12 +14,15 @@ import { NcButton } from '@nextcloud/vue'
 // with vue 3.3:
 // const props = defineProps<IDialogButton>()
 
-const props = defineProps<{
+const props = withDefaults(defineProps<{
 	callback: IDialogButton['callback'],
 	label: IDialogButton['label'],
-	icon: IDialogButton['icon'],
-	type: IDialogButton['type'],
-}>()
+	icon?: IDialogButton['icon'],
+	type?: IDialogButton['type'],
+}>(), {
+	icon: undefined,
+	type: 'secondary',
+})
 
 const emit = defineEmits<(e: 'click', event: MouseEvent) => void>()