Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Undo method & translations #106

Merged
merged 1 commit into from Aug 17, 2020
Merged

Add Undo method & translations #106

merged 1 commit into from Aug 17, 2020

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Mar 23, 2020

image

@skjnldsv skjnldsv added the enhancement New feature or request label Mar 23, 2020
@skjnldsv skjnldsv self-assigned this Mar 23, 2020
lib/toast.ts Show resolved Hide resolved
lib/toast.ts Outdated Show resolved Hide resolved
lib/toast.ts Outdated Show resolved Hide resolved
lib/toast.ts Outdated Show resolved Hide resolved
lib/toast.ts Outdated Show resolved Hide resolved
@jancborchardt

This comment has been minimized.

@gary-kim

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@jancborchardt
Copy link

Cause it would be much nicer if we standardize the wording in the component as well and don’t have to make sure every app does it properly. That way it would work for "Deleted", "Moved", "Renamed" etc., which can be used for files, forms, calendar, contacts, … and we only have to do the logic and translation once, in the component.

Then we would have to have one method per type of Undo?
undoDeleted, undoMoved, undoRenamed? Or even if it's not from the method name itself, it will have to be passed as an argument somewhere.

I'm all in for standardisation, but this is too much here :)

I’d rather we have the work here centrally, than have to check it in every single place. The action and UI is standardized and so should the wording and how it is displayed. It will ease the work for all developers, and make it consistent for all users.

If we don’t do that, at least make sure the wording recommendations are in the documentation (which hopefully all devs will read).

@skjnldsv

This comment has been minimized.

@skjnldsv skjnldsv force-pushed the enh/undo branch 2 times, most recently from 7c9a32d to f43bb7b Compare July 9, 2020 08:57
@skjnldsv
Copy link
Contributor Author

All good! Please review everyone 🎉

@skjnldsv skjnldsv changed the title [WIP] Add Undo method Add Undo method & translations Aug 14, 2020
@skjnldsv skjnldsv force-pushed the enh/undo branch 2 times, most recently from e53a6b4 to e29b5bd Compare August 14, 2020 13:01
@skjnldsv
Copy link
Contributor Author

So, it seems something broke, I don't understand why.
I pushed whatever I had left, @juliushaertl maybe you could have a quick look? Since you had more experience with rollup :'(

Or anyone, It seems it's a config issue where the imports are weird misbehaving. I don't understand why

@skjnldsv skjnldsv force-pushed the enh/undo branch 3 times, most recently from a3e2494 to b92d39d Compare August 17, 2020 08:18
Comment on lines +1 to +20
#
# Translators:
# Brendan Abolivier <transifex@brendanabolivier.com>, 2020
# gud bes <gudbes@protonmail.com>, 2020
# Greg Greg <grena@grenabox.fr>, 2020
# Luclu7 <theluc7andcompagnie@gmail.com>, 2020
# Julien Veyssier <eneiluj@gmx.fr>, 2020
#
msgid ""
msgstr ""
"Last-Translator: Julien Veyssier <eneiluj@gmx.fr>, 2020\n"
"Language-Team: French (https://www.transifex.com/nextcloud/teams/64236/fr/)\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Language: fr\n"
"Plural-Forms: nplurals=2; plural=(n > 1);\n"

#: src/components/MultiselectTags/MultiselectTags.vue:170
#: lib/toast.ts:187
msgid "Undo"
msgstr "Annuler"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy file, will get overrided, it's fine

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
}

export interface ToastOptions {
/**
* Defines the timeout after which the toast is closed. Set to 0 to have a persistent toast.
* Defines the timeout after which the toast is closed. Set to -1 to have a persistent toast.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #107 and #111 this is not intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants