Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export FilePickerType enum #556

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Export FilePickerType enum #556

merged 1 commit into from
Apr 8, 2022

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Apr 7, 2022

Allow users of this package to use the more easily grokked

getFilePickerBuilder('Choose a file or folder to transfer')
	.setType(FilePickerType.Choose)
	.build()

instead of

getFilePickerBuilder('Choose a file or folder to transfer')
	.setType(1)
	.build()

@Pytal Pytal self-assigned this Apr 7, 2022
ChristophWurst
ChristophWurst approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@Pytal
Export FilePickerType enum
5435985 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/export-file-picker-type-enum branch from 6476d59 to 5435985 Compare April 8, 2022 02:35
@Pytal
Copy link
Contributor Author

Pytal commented Apr 8, 2022

CI hanged so trying again

@nickvergessen
Copy link
Contributor

Was not CI hanging, but after #546 the required tests where not adjusted. Fixed it now.

@nickvergessen nickvergessen merged commit d782cdc into master Apr 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/export-file-picker-type-enum branch April 8, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pytal @nickvergessen @ChristophWurst