Url encode svg and ship it #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
nickvergessen,
raimund-schluessler,
juliushaertl and
szaimen
| @@ -16,7 +16,7 @@ npm i -S @nextcloud/dialogs | |||
|
|
|||
| ```js | |||
| import { showMessage, showInfo, showSuccess, showWarning, showError } from '@nextcloud/dialogs' | |||
| import '@nextcloud/dialogs/styles/toast.scss' | |||
| import '@nextcloud/dialogs/dist/index.css' | |||
There was a problem hiding this comment.
🙈
Break all the apps!
Bump major version?
There was a problem hiding this comment.
Yep, will be a major
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/styling-icons
branch
from
3a335cb
to
47de0f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when checking the server's css.
We do not import or copy the assets, which means we're just importing the css without any changes to the url resolving
https://github.com/nextcloud/server/blob/99191167167dd6c98dc3ae9b0eca947526e7939f/core/css/server.scss#L10
By encoding this, we're making sure every release here will works out of the box