feat(new-menu): Allow to set the category for entries

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

__tests__/newFileMenu.spec.ts

@@ -1,6 +1,6 @@
 import { describe, expect, test, vi, afterEach } from 'vitest'
 
-import { NewFileMenu, getNewFileMenu, type Entry } from '../lib/newFileMenu'
+import { NewFileMenu, NewMenuEntryCategory, getNewFileMenu, type Entry } from '../lib/newFileMenu'
 import logger from '../lib/utils/logger'
 import { Folder, Permission, addNewFileMenuEntry, getNewFileMenuEntries } from '../lib'
 
@@ -196,6 +196,39 @@ describe('NewFileMenu addEntry', () => {
 			} as unknown as Entry)
 		}).toThrowError('Invalid handler property')
 	})
+
+	test('Adding a Entry without category', () => {
+		const newFileMenu = new NewFileMenu()
+		const entry = {
+			id: 'empty-file',
+			displayName: 'Create empty file',
+			templateName: 'New file.txt',
+			iconClass: 'icon-filetype-text',
+			handler: () => {},
+		}
+		newFileMenu.registerEntry(entry)
+
+		const entries = newFileMenu.getEntries()
+		expect(entries).toHaveLength(1)
+		expect(entries[0].category).toBe(NewMenuEntryCategory.CreateNew)
+	})
+
+	test('Adding a Entry with category', () => {
+		const newFileMenu = new NewFileMenu()
+		const entry = {
+			id: 'empty-file',
+			category: NewMenuEntryCategory.Other,
+			displayName: 'Create empty file',
+			templateName: 'New file.txt',
+			iconClass: 'icon-filetype-text',
+			handler: () => {},
+		}
+		newFileMenu.registerEntry(entry)
+
+		const entries = newFileMenu.getEntries()
+		expect(entries).toHaveLength(1)
+		expect(entries[0].category).toBe(NewMenuEntryCategory.Other)
+	})
 })
 
 describe('NewFileMenu removeEntry', () => {

lib/newFileMenu.ts

@@ -23,10 +23,33 @@
 import type { Folder, Node } from './index'
 import logger from './utils/logger'
 
+export enum NewMenuEntryCategory {
+	/**
+	 * For actions where the user is intended to upload from their device
+	 */
+	UploadFromDevice = 0,
+	/**
+	 * For actions that create new nodes on the server without uploading
+	 */
+	CreateNew = 1,
+	/**
+	 * For everything not matching the other categories
+	 */
+	Other = 2,
+}
+
 export interface Entry {
 	/** Unique ID */
 	id: string
 
+	/**
+	 * Category to put this entry in
+	 * (supported since Nextcloud 30)
+	 * @since 3.3.0
+	 * @default NewMenuEntryCategory.CreateNew
+	 */
+	category?: NewMenuEntryCategory
+
 	/** Translatable string displayed in the menu */
 	displayName: string
 
@@ -65,6 +88,7 @@ export class NewFileMenu {
 
 	public registerEntry(entry: Entry) {
 		this.validateEntry(entry)
+		entry.category = entry.category ?? NewMenuEntryCategory.CreateNew
 		this._entries.push(entry)
 	}