Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Node): Handle slash as root path for public webdav endpoint #847

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 20, 2023

dirname and path both depend on the root property, but in case of the webdav endpoint the root is just / so in this case we need to remove the remote URL part first before we remove the root.

before after
source: http://foo.com/public.php/webdav/bar
root: /
path: /foo.com/public.php/webdav/bar
source: http://foo.com/public.php/webdav/bar
root: /
path: /bar

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2feb511) 77.33% compared to head (a5c7260) 77.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   77.33%   77.75%   +0.41%     
==========================================
  Files          17       17              
  Lines         428      436       +8     
  Branches      113      115       +2     
==========================================
+ Hits          331      339       +8     
  Misses         97       97              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skjnldsv skjnldsv merged commit 2351742 into master Dec 21, 2023
10 checks passed
@skjnldsv skjnldsv deleted the fix/handle-webdav-endpoint branch December 21, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants