fix(dav): davResultToNode real owner #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
=======================================
Coverage 77.75% 77.75%
=======================================
Files 17 17
Lines 436 436
Branches 115 116 +1
=======================================
Hits 339 339
Misses 97 97 ☔ View full report in Codecov by Sentry. |
susnux
approved these changes
Jan 9, 2024
susnux
reviewed
Jan 9, 2024
| @@ -143,7 +143,7 @@ export const getFavoriteNodes = async (davClient: WebDAVClient, path = '/', davR | |||
| export const davResultToNode = function(node: FileStat, filesRoot = davRootPath, remoteURL = davRemoteURL): Node { | |||
| const props = node.props as ResponseProps | |||
There was a problem hiding this comment.
Maybe add owner-id to ResponseProps as string | undefined? Then you do not need to cast later and it is more clear that it exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.