feat: Add and export isFilenameValid function
#951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/export-filename-unti
branch
from
b8edb41
to
8a06891
Compare
Bundle ReportChanges will increase total bundle size by 1.04kB ⬆️
|
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
reviewed
May 16, 2024
| }) | ||
|
|
||
| it('works for valid filenames', async () => { | ||
| const { isFilenameValid } = await import('../lib/index') |
There was a problem hiding this comment.
We need to reset the module for every test to reset the cached forbidden characters
There was a problem hiding this comment.
Doesn't Vitest have reset module option?
There was a problem hiding this comment.
Doesn't Vitest have reset module option?
Yes see rest of the file, but it can only reset the node cache. So top level imports do not work. It only resets the module cache -> next import will be freshly evaluated.
There was a problem hiding this comment.
Why are we always on edge cases 🙈 😭
ShGKme
approved these changes
May 16, 2024
skjnldsv
approved these changes
May 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.