Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Add fallback for owner of dav nodes on public shares #959

Merged
merged 1 commit into from
May 22, 2024

Conversation

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review labels May 21, 2024
@susnux susnux requested review from skjnldsv and Pytal May 21, 2024 16:59
@susnux susnux mentioned this pull request May 21, 2024
Copy link

codecov bot commented May 21, 2024

Bundle Report

Changes will increase total bundle size by 398 bytes ⬆️

Bundle name Size Change
@nextcloud/files-esm 105.61kB 199 bytes ⬆️
@nextcloud/files-cjs 106.55kB 199 bytes ⬆️

@skjnldsv
Copy link
Contributor

skjnldsv commented May 22, 2024

Wouldn't have this been better to have getCurrentUser returns anonymous translated values?

{
	uid: 'anonymous',
	displayName: t('Anonymous account'),
	isAdmin: false,
}

@susnux
Copy link
Contributor Author

susnux commented May 22, 2024

I do not think so, because it is meant to return a user, but in this case it is no real user.
So return null is fine.

Otherwise you can have an issue if you have a real user called anonymous

@susnux susnux merged commit 19635cf into main May 22, 2024
16 checks passed
@susnux susnux deleted the fix/files-public-share branch May 22, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The FilePicker does not load for moving or copying a file or a folder when not logged in
2 participants