Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): remove logger debug on attributes drop #963

Closed
wants to merge 1 commit into from
Closed

fix(node): remove logger debug on attributes drop #963

wants to merge 1 commit into from

Conversation

skjnldsv
Copy link
Contributor

This was a bit over the top 🙈
image

@skjnldsv
fix(node): remove logger debug on attributes drop
1784574 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from susnux May 23, 2024 09:03
@skjnldsv skjnldsv self-assigned this May 23, 2024
@codecov Codecov
Copy link

codecov bot commented May 23, 2024

Bundle Report

Changes will decrease total bundle size by 182 bytes ⬇️

Bundle name Size Change
@nextcloud/files-esm 108.75kB 91 bytes ⬇️
@nextcloud/files-cjs 109.78kB 91 bytes ⬇️

susnux
susnux approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much even for developing? But ok :)

@susnux
Copy link
Contributor

susnux commented May 29, 2024

I think we can close

@susnux susnux closed this May 29, 2024
@susnux susnux deleted the fix/no-debug branch May 29, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees

@skjnldsv skjnldsv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skjnldsv @susnux