Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Node): Do not drop readonly attributes but only forbid updating them #967

Merged
merged 2 commits into from
May 29, 2024
Merged

fix(Node): Do not drop readonly attributes but only forbid updating them #967

merged 2 commits into from
May 29, 2024

Commits on May 29, 2024

  1. fix(Node): Do not drop readonly attributes but only forbid updating them 

    Attributes that are readonly should still be listed in the `attributes` getter,
otherwise this is a hard breaking change as a lot of apps already depend on `attributes`.
So instead only ensure that readonly attributes are skipped by the proxy handler.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 29, 2024
    Configuration menu
    Copy the full SHA
    4a7ece4 View commit details
    Browse the repository at this point in the history

  2. fix: Add deprecation warning when accessing toplevel attributes throu… 

    …gh Node.attributes

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed May 29, 2024
    Configuration menu
    Copy the full SHA
    12b6dcc View commit details
    Browse the repository at this point in the history