Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix davResultToNode on public shares and provide isPublicShare helper #993

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Fix davResultToNode on public shares and provide isPublicShare helper #993

merged 3 commits into from
Jun 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 18, 2024

  1. Provide a helper that determines if you are on a public share
  2. Use that helper to fix public share detection in davResultToNode

@susnux
feat: Provide isPublicShare to determine if the current page is a p…
607066d 
…ublic share

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix: Properly handle public shares for davResultToNode
c386ac9 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working enhancement New feature or request 3. to review labels Jun 18, 2024
@susnux susnux requested review from skjnldsv and Pytal June 18, 2024 13:28
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited

Bundle Report

Changes will increase total bundle size by 37 bytes ⬆️

Bundle name Size Change
@nextcloud/files-esm 95.15kB 6 bytes ⬆️
@nextcloud/files-esm-cjs 96.26kB 31 bytes ⬆️

@susnux
test: Add missing tests for public shares
bccf9e7 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 349e7bd into main Jun 18, 2024
16 of 17 checks passed
@susnux susnux deleted the fix/public-share branch June 18, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@susnux @skjnldsv