Replace dash with underscore for applying proper languages #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
ChristophWurst
approved these changes
Sep 7, 2020
delete-merged-branch
bot
deleted the
bugfix/noid/use-proper-languagecode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de_DEor any other language that uses a_separator in the identifier.@nextcloud/vuewhich comes with translations that are depending on the result of getLanguagehttps://github.com/nextcloud/nextcloud-l10n/blob/master/lib/index.ts#L31OC.getLanguagejust returns the lang value of the<html>element however-are used there instead of_so the language cannot be found in the provided pot files of@nextcloud/vue:Before:
After: