-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate publish to npm #91
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv @LukasReschke What is the state with npm tokens on repos inside this org these days? Wasn't this something we abandonded due to the large amount of people with push access? |
Drafting pending discussions :) |
Let's either use a locked down environment or if that isn't feasible the https://github.com/nextcloud-releases organization? :) |
@ChristophWurst @juliushaertl @LukasReschke forked to https://github.com/nextcloud-releases/nextcloud-typings — as noted in nextcloud-libraries/nextcloud-password-confirmation#220 (review) we'll also have to set the secret token in the new repo or at the organization level :) |
But you still add the workflow here. Then we tag releases here and also push them over to the fork. Only in the forked repo the workflow should run. You could add something like an condition that the workflow only runs when the npm token is available. |
I think there is also a way to check the author permission level for the release in the github action. |
Couldn't find that in the docs 🤔 made a PR with @ChristophWurst's suggestion in the https://github.com/nextcloud/.github repo |
Closing in favour of nextcloud/.github#14 |
That would be a workflow step, not from github's docs :) |
Add a workflow to publish this package to npm on release, also needs an
NPM_TOKEN
secret :)Similar to the workflows as seen in the eslint-config and webpack-vue-config repos.