fix(lib): Libraries do not need to be minified by default as this is …

…done on app level

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

__tests__/libconfig.spec.ts

@@ -11,7 +11,7 @@ import { LibraryOptions, createLibConfig } from '../lib/libConfig'
 describe('library config', () => {
 	describe('workaround vite#14515 minify bug', () => {
 		it('minifies using esbuild by default', async () => {
-			const resolved = await createConfig('build')
+			const resolved = await createConfig('build', 'production', { minify: true })
 
 			// there is no minify plugin
 			expect(resolved.plugins.filter((plugin) => plugin.name === 'esbuild-minify').length).toBe(0)
@@ -72,7 +72,17 @@ describe('library config', () => {
 		})
 	})
 
-	const createConfig = async (command: 'build' | 'serve' = 'build', mode: 'development' | 'production' = 'production', options?: LibraryOptions) => await resolveConfig(await createLibConfig({
-		main: 'src/main.js',
-	}, options)({ command, mode, isSsrBuild: false }), command)
+	const createConfig = async (
+		command: 'build' | 'serve' = 'build',
+		mode: 'development' | 'production' = 'production',
+		options?: LibraryOptions,
+	) => {
+		return await resolveConfig(
+			await createLibConfig(
+				{
+					main: 'src/main.js',
+				},
+				options,
+			)({ command, mode, isSsrBuild: false }), command)
+	}
 })

lib/libConfig.ts

@@ -17,6 +17,12 @@ import { ImportCSSPlugin } from './plugins/ImportCSS.js'
 type OutputOptions = BuildOptions['rollupOptions']['output']
 
 export interface LibraryOptions extends BaseOptions {
+	/**
+	 * Whether to minify the output
+	 * @default false For libraries the code is not minified by default for better DX. Usually it is not needed: a library will be minified as a part of an app bundling.
+	 */
+	minify?: boolean
+
 	/**
 	 * Options for the rollup node externals plugin
 	 *
@@ -52,7 +58,13 @@ export interface LibraryOptions extends BaseOptions {
  */
 export const createLibConfig = (entries: { [entryAlias: string]: string }, options: LibraryOptions = {}): UserConfigFn => {
 	// Add default values for options
-	options = { config: {}, nodeExternalsOptions: {}, libraryFormats: ['es'], ...options }
+	options = {
+		config: {},
+		minify: false,
+		nodeExternalsOptions: {},
+		libraryFormats: ['es'],
+		...options,
+	}
 
 	const node = nodeExternals({
 		builtins: true, // Mark all node core modules, like `path` as external
@@ -137,7 +149,7 @@ export const createLibConfig = (entries: { [entryAlias: string]: string }, optio
 						formats: options.libraryFormats,
 					},
 					// workaround, see above
-					minify: options.minify ?? env.mode === 'production' ? 'esbuild' : false,
+					minify: (options.minify ?? env.mode === 'production') ? 'esbuild' : false,
 					cssCodeSplit: true,
 					outDir: 'dist',
 					rollupOptions: {