Skip to content

Commit

Permalink
Merge pull request #17 from nextcloud-libraries/prepare-bugfix-release
Browse files Browse the repository at this point in the history
chore: Prepare new bugfix release
  • Loading branch information
susnux committed Sep 16, 2023
2 parents a816607 + 87aa258 commit de57a84
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,11 @@ export default createLibConfig({

### Inlining / injecting CSS
You can enable inlining CSS code, but please note that this is handled differently for apps and libraries.
* Apps will inline the CSS by dynamically inject it as `script` tags
* Libraries will extract the CSS to the dist/assets directory and import it in the entry point

For apps any styles can be injected in the JS by dynamically inject the styles in the document (creating `<style>` tags).
But this only works in DOM environments, so for libraries this might not work (e.g. while testing in the Node environment).

So for apps the CSS will still be extracted by Vite, but the extracted CSS assets will be imported.
This way the library user can decide how to handle the imported CSS without relying on a DOM environment.
So for libraries the CSS will still be extracted by Vite, but the extracted CSS assets will be imported.
This way the library user can decide how to handle the imported CSS without relying on a DOM environment.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"homepage": "https://github.com/nextcloud/nextcloud-vite-config",
"license": "AGPL-3.0-or-later",
"version": "1.0.0-beta.18",
"version": "1.0.0-beta.19",
"type": "module",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down

0 comments on commit de57a84

Please sign in to comment.