Skip to content

Commit

Permalink
fix(NcHeaderMenu): mouse in now pointer
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
  • Loading branch information
emoral435 committed Jan 23, 2024
1 parent b570762 commit 1aefe9b
Showing 1 changed file with 18 additions and 16 deletions.
34 changes: 18 additions & 16 deletions src/components/NcHeaderMenu/NcHeaderMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -73,18 +73,21 @@ export default {
class="header-menu"
v-on="listeners">
<!-- Trigger -->
<button :id="isNav ? triggerId : null"
<NcButton :id="isNav ? triggerId : null"
ref="trigger"
class="header-menu__trigger button-vue"
type="tertiary-no-background"
class="header-menu__trigger"
:aria-label="ariaLabel"
:aria-describedby="description ? descriptionId : null"
:aria-controls="`header-menu-${id}`"
:aria-expanded="opened.toString()"
@click.prevent="toggleMenu">
<!-- @slot Icon trigger slot. Make sure the svg path
<template #icon>
<!-- @slot Icon trigger slot. Make sure the svg path
is at least 16px. Usually mdi icon works at 20px -->
<slot name="trigger" />
</button>
<slot name="trigger" />
</template>
</NcButton>

<span v-if="description"
:id="descriptionId"
Expand Down Expand Up @@ -115,9 +118,15 @@ import GenRandomId from '../../utils/GenRandomId.js'
import { clickOutsideOptions } from '../../mixins/index.js'
import { getTrapStack } from '../../utils/focusTrap.js'
import NcButton from '../NcButton/index.js'
export default {
name: 'NcHeaderMenu',
components: {
NcButton,
},
directives: {
ClickOutside,
},
Expand Down Expand Up @@ -339,17 +348,9 @@ $externalMargin: 8px;
height: var(--header-height);
&__trigger {
display: flex;
align-items: center;
justify-content: center;
width: var(--header-height);
height: var(--header-height);
margin: 0;
padding: 0;
cursor: pointer;
opacity: .85;
background-color: transparent;
border: none;
// header is filled with primary or image background
filter: none !important;
Expand All @@ -363,9 +364,10 @@ $externalMargin: 8px;
opacity: 1;
}
&__trigger:focus-visible {
outline: none;
}
#{&}__trigger:focus-visible {
outline: none !important;
box-shadow: none !important;
}
&__wrapper {
position: fixed;
Expand Down

0 comments on commit 1aefe9b

Please sign in to comment.