Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationItem should allow simple click actions #11

Closed
ChristophWurst opened this issue Aug 20, 2018 · 4 comments
Closed

NavigationItem should allow simple click actions #11

ChristophWurst opened this issue Aug 20, 2018 · 4 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: app-navigation Related to the app-navigation component

Comments

@ChristophWurst
Copy link
Contributor

In order to use this component for Mail, I need to add an entry to the app navigation for the expand/collapse folders feature. This entry neither points to an external URL, nor is it connected to the Vue router. It's a simple "button" with a click action.

Would that be possible, @skjnldsv?

@ChristophWurst ChristophWurst added the enhancement New feature or request label Aug 20, 2018
@skjnldsv
Copy link
Contributor

@ChristophWurst You have full entries without any feedbacks?
Like what?

Usually the collapsible are managed with a collapsible button, but it's not yet in the standard.
I need to be sure of what you need before adding this :)

@skjnldsv skjnldsv added the feature: app-navigation Related to the app-navigation component label Aug 20, 2018
@skjnldsv skjnldsv mentioned this issue Aug 20, 2018
13 tasks
@ChristophWurst
Copy link
Contributor Author

The feature works as follows: an IMAP account can have large numbers of folders (mailboxes). Instead of cluttering the UI with these, we hide all non-special (non-inbox, non-sent, non-draft, …) folders be default and instead, show an entry Show all. When the users clicks this entry, the full list is shown. On the bottom of the list, there is an entry to collapse the list again.

This could, of course, be implemented as an standard component. But I don't mind implementing this just for Mail as long as this is specific to one app.

@skjnldsv
Copy link
Contributor

Ah yes, it make sense!
Let's get this in :)

@skjnldsv skjnldsv reopened this Aug 20, 2018
@skjnldsv skjnldsv added 2. developing Work in progress 3. to review Waiting for reviews 1. to develop Accepted and waiting to be taken care of and removed 2. developing Work in progress 3. to review Waiting for reviews labels Aug 20, 2018
@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 20, 2018

  • add action handler
  • check proper implementation of action or toggleCollapse
  • collapse button option
  • default collapse state

@skjnldsv skjnldsv self-assigned this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

No branches or pull requests

2 participants