Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init component repository #10

Merged
merged 16 commits into from
Sep 11, 2018
Merged

Init component repository #10

merged 16 commits into from
Sep 11, 2018

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Aug 20, 2018

🚧 WIP 🚧

skjnldsv and others added 4 commits August 17, 2018 16:57
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
https://webpack.js.org/configuration/resolve/#resolve-alias

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Optimize exports for selective imports
@skjnldsv skjnldsv added enhancement New feature or request 2. developing Work in progress feature: popover Related to the popovermenu component feature: app-navigation Related to the app-navigation component labels Aug 20, 2018
@skjnldsv skjnldsv added this to the 1.0.0 milestone Aug 20, 2018
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@ChristophWurst
Copy link
Contributor

Just so that we're on the same page: will this be released as a single npm package?

I kind of thought the components would be individual packages.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer
Copy link
Contributor

rullzer commented Aug 25, 2018

@skjnldsv see the question by @ChristophWurst

@skjnldsv
Copy link
Contributor Author

@ChristophWurst we wanted to at first but in the end this is really difficult to maintain :)
We decided to go for a single one, but you can import individual components like
import { AppNavigation } from 'vue-components'

@ChristophWurst
Copy link
Contributor

As discussed with @juliushaertl separate packages would mean more maintenance effort (separate npm/webpack configs) and we'd have dependencies of components inside the library anyway.

Let's give the single package approach a try and if it's problematic we can always split later on 👍

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the feature: datepicker Related to the date/time picker component label Sep 11, 2018
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit c84fc85 into master Sep 11, 2018
@skjnldsv skjnldsv deleted the init branch September 11, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request feature: app-navigation Related to the app-navigation component feature: datepicker Related to the date/time picker component feature: popover Related to the popovermenu component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants