Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action component #12

Closed
juliushaertl opened this issue Aug 26, 2018 · 2 comments
Closed

Action component #12

juliushaertl opened this issue Aug 26, 2018 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion feature: actions Related to the actions components
Milestone

Comments

@juliushaertl
Copy link
Contributor

As discussed with @skjnldsv and @jancborchardt we should add a action component that will take a list of actions and render the action icon directly if there is only one. If multiple actions are added, a 3-dots menu with a popover menu should be shown.

@jancborchardt
Copy link
Contributor

This also needs a special case for the files menu for example – where the share action is shown directly.

Or do we split the actions there, into one share component and one actions component?

@skjnldsv
Copy link
Contributor

skjnldsv commented Sep 5, 2018

@jancborchardt Julius and I decided it would be easier to have two action components then. :)
One with only one action: share and the other with everything left ;)

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion feature: actions Related to the actions components labels Sep 11, 2018
@skjnldsv skjnldsv added this to the 0.1.4 milestone Sep 24, 2018
@skjnldsv skjnldsv modified the milestones: 0.2, 0.3.0, 0.2.1 Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion feature: actions Related to the actions components
Projects
None yet
Development

No branches or pull requests

3 participants