Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide color picker #138

Closed
georgehrke opened this issue Dec 1, 2018 · 17 comments · Fixed by #571
Closed

Provide color picker #138

georgehrke opened this issue Dec 1, 2018 · 17 comments · Fixed by #571
Assignees
Labels
2. developing Work in progress component Component discussion and/or suggestion enhancement New feature or request

Comments

@georgehrke
Copy link
Contributor

There should be a standardised color-picker in Nextcloud because it's needed in many places.
E.g.:

This is the color-picker in the Calendar app (v1):
Safari, IE:
55d7a0ab-ac58-4ea7-8ccd-70f6baa5a3cd

Firefox, Chrome, Edge:
cbcfbb97-beb7-4d25-a678-40c04ee397f3

It provides a default set of colors plus a random color option in Safari, IE and a real color-picker for browsers that natively support it.
https://caniuse.com/#feat=input-color

The color-picker should also work inside the popover menu.

@georgehrke georgehrke added the 1. to develop Accepted and waiting to be taken care of label Dec 1, 2018
@georgehrke georgehrke added the enhancement New feature or request label Dec 1, 2018
@ChristophWurst
Copy link
Contributor

* mail app (cc @ChristophWurst)

We don't need one right now, but I like the idea of having a component for this 👍

@juliushaertl
Copy link
Contributor

It provides a default set of colors plus a random color option in Safari, IE and a real color-picker for browsers that natively support it.

If we write a component, we should make sure there is also a proper picker for IE/Safari, where the input color element is not supported. Otherwise 👍

@georgehrke
Copy link
Contributor Author

Just for reference:
This is the color-picker from Google calendar
212f8ef0-baba-4a6a-99e2-8872721da1ba

@skjnldsv skjnldsv added the component Component discussion and/or suggestion label Jan 8, 2019
@raimund-schluessler
Copy link
Contributor

I wrote a colorpicker component for the Tasks app, see https://github.com/nextcloud/tasks/blob/vue/src/components/Colorpicker.vue. It is one of the first vue components I wrote, so it is probably badly written 🙈 I also reused some code from previous implementations.

But maybe it a first iteration to improve on.

@skjnldsv
Copy link
Contributor

@raimund-schluessler I'm sure it'll be amazing! :D
Give yourself some credit!!!

Can we see some screenshots ? 🎉

@georgehrke
Copy link
Contributor Author

ping @raimund-schluessler ^ :)

@ChristophWurst
Copy link
Contributor

We don't need one right now, but I like the idea of having a component for this +1

Well nextcloud/mail#486 🤷‍♂️

@marcoambrosini marcoambrosini self-assigned this Aug 30, 2019
@marcoambrosini
Copy link
Contributor

marcoambrosini commented Aug 30, 2019

This is the color-picker from Google calendar

I Like the google solution: easy enough for somebody that doesn't need to customize much, but also gives the option to pick a custom color. I made a mock up so we can discuss the design: https://www.figma.com/file/4th1eQVONZguVoDXMwnDJT/nextcloud-color-picker?node-id=0%3A1
@nextcloud/designers

@jancborchardt
Copy link
Contributor

Looking super good @ma12-co! The only thing I would change is to make the colors shown in circles instead of rounded squares. This is also what we already do in the Mail app e.g.

(Btw @georgehrke kinda related, the checkmark-to-activate interface in Google Calendar is very nice – we should probably do that too to be very obvious what is currently active.)

@marcoambrosini
Copy link
Contributor

Thanks @jancborchardt!

The only thing I would change is to make the colors shown in circles instead of rounded squares.

I just updated it :)

@georgehrke
Copy link
Contributor Author

(Btw @georgehrke kinda related, the checkmark-to-activate interface in Google Calendar is very nice – we should probably do that too to be very obvious what is currently active.)

Absolutely! Should that be something that we put into vue components? (similar to the
AppNavigationIconBullet) Or is it too calendar-app-specific?

@marcoambrosini
Copy link
Contributor

(Btw @georgehrke kinda related, the checkmark-to-activate interface in Google Calendar is very nice – we should probably do that too to be very obvious what is currently active.)

Added to the mockup as well!

@georgehrke
Copy link
Contributor Author

@ma12-co I think @jancborchardt talked about the checkbox in front of the calendar name :)

@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 30, 2019

@georgehrke I guess we can link an event to the bullet click, then you could do whatever you want. Thought it's not very discoverable. I'd put this into the menu.
And didn't you wanted an appNavCheckbox that could be coloured?

EDIT: ahaha, great mind synchronisation Georg ;)

@marcoambrosini
Copy link
Contributor

@ma12-co I think @jancborchardt talked about the checkbox in front of the calendar name :)

Oh I get it, my bad!

@marcoambrosini marcoambrosini added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Aug 30, 2019
@georgehrke
Copy link
Contributor Author

@ma12-co Thank you for taking this up. Much appreciated! :)

@jancborchardt
Copy link
Contributor

@ma12-co I think @jancborchardt talked about the checkbox in front of the calendar name :)

Yup, but adding it to the active color to indicate is also good. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress component Component discussion and/or suggestion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants