-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide color picker #138
Comments
We don't need one right now, but I like the idea of having a component for this 👍 |
If we write a component, we should make sure there is also a proper picker for IE/Safari, where the input color element is not supported. Otherwise 👍 |
I wrote a colorpicker component for the Tasks app, see https://github.com/nextcloud/tasks/blob/vue/src/components/Colorpicker.vue. It is one of the first vue components I wrote, so it is probably badly written 🙈 I also reused some code from previous implementations. But maybe it a first iteration to improve on. |
@raimund-schluessler I'm sure it'll be amazing! :D Can we see some screenshots ? 🎉 |
ping @raimund-schluessler ^ :) |
Well nextcloud/mail#486 🤷♂️ |
I Like the google solution: easy enough for somebody that doesn't need to customize much, but also gives the option to pick a custom color. I made a mock up so we can discuss the design: https://www.figma.com/file/4th1eQVONZguVoDXMwnDJT/nextcloud-color-picker?node-id=0%3A1 |
Looking super good @ma12-co! The only thing I would change is to make the colors shown in circles instead of rounded squares. This is also what we already do in the Mail app e.g. (Btw @georgehrke kinda related, the checkmark-to-activate interface in Google Calendar is very nice – we should probably do that too to be very obvious what is currently active.) |
Thanks @jancborchardt!
I just updated it :) |
Absolutely! Should that be something that we put into vue components? (similar to the |
Added to the mockup as well! |
@ma12-co I think @jancborchardt talked about the checkbox in front of the calendar name :) |
@georgehrke I guess we can link an event to the bullet click, then you could do whatever you want. Thought it's not very discoverable. I'd put this into the menu. EDIT: ahaha, great mind synchronisation Georg ;) |
Oh I get it, my bad! |
@ma12-co Thank you for taking this up. Much appreciated! :) |
Yup, but adding it to the active color to indicate is also good. :) |
There should be a standardised color-picker in Nextcloud because it's needed in many places.
E.g.:
This is the color-picker in the Calendar app (v1):
![55d7a0ab-ac58-4ea7-8ccd-70f6baa5a3cd](https://user-images.githubusercontent.com/1250540/49329644-6e4e9f00-f582-11e8-9cf1-517132488534.png)
Safari, IE:
Firefox, Chrome, Edge:
![cbcfbb97-beb7-4d25-a678-40c04ee397f3](https://user-images.githubusercontent.com/1250540/49329688-05b3f200-f583-11e8-83f3-5ef41acc34cc.png)
It provides a default set of colors plus a random color option in Safari, IE and a real color-picker for browsers that natively support it.
https://caniuse.com/#feat=input-color
The color-picker should also work inside the popover menu.
The text was updated successfully, but these errors were encountered: