Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email accounts colors: Make sure there are no color conflicts [$5] #486

Open
joaojotta opened this issue Aug 30, 2017 · 20 comments
Open

Email accounts colors: Make sure there are no color conflicts [$5] #486

joaojotta opened this issue Aug 30, 2017 · 20 comments

Comments

@joaojotta
Copy link

joaojotta commented Aug 30, 2017

So, this doesn't need a lot to understand.

Issue/Request, there's simply no way to customize colors on different email accounts on the Mail app. It's just setup randomly by default (or generated by the email account name).
This caused me to have all 3 accounts with the same color.

Any way to add this?

Thank you!


There is a $5 open bounty on this issue. Add to the bounty at Bountysource.

@ChristophWurst
Copy link
Member

@skjnldsv any ideas? :)

@jancborchardt
Copy link
Member

We could add a picker, just like in the calendar? What do you use there @georgehrke @tcitworld @raghunayyar?

@georgehrke
Copy link
Member

We don't use any special library. It's just 8 colored boxes with an additional input for HTML 5 Input color

@tcitworld
Copy link
Member

Native color picker or random color button as default if the native color picker is not available.

@skjnldsv
Copy link
Member

skjnldsv commented Sep 5, 2017

Agree with the calendar way! :)

@joaojotta
Copy link
Author

Choosing a color from existing 8 or customizing would be amazing! Whatever is easier.

@jospoortvliet jospoortvliet changed the title Email accounts colors Email accounts colors [$5] Aug 23, 2018
@jancborchardt
Copy link
Member

Recently I also ran into this, where my 2 (!) accounts have the same color. We could do it similar to the Calendar where a newly created calendar picks a color which has not been used. So if the autogenerated color is too close to one which already exists, we simply move along a bit on the color wheel?

@alexanderdd
Copy link

Please, implement the same color picker as in calendar (it's explained above). Wouldn't it make sense to use the same color picker across all (or all official) NC apps?

Colors convey meaning. My work calendar is yellow, my personal calendar is blue. I would like my work/personal email to be yellow/blue too.

@jancborchardt
Copy link
Member

@alexanderdd please note that this app is open source, so you can help in several ways making this happen: Contribute code, open a bounty for it on Bountysource, spread the word to get developers to implement this, etc etc.

We discuss and decide what makes sense regarding design and development in a step-by-step process:

  1. First step is to not have the colors of 2 accounts conflict. If you have only 2 accounts which happen to get the same colors through the algorithm, you shouldn’t need to fix it yourself via a color picker. Most people don’t change defaults, so we need this anyway.
  2. In the future, and if possibly people help out, we can have a color picker there.

@alexanderdd
Copy link

alexanderdd commented Nov 30, 2018 via email

@jancborchardt jancborchardt changed the title Email accounts colors [$5] Email accounts colors: Make sure there are no color conflicts [$5] Feb 29, 2020
@xMartin
Copy link
Member

xMartin commented Mar 27, 2020

How about defining, say, 12 fixed colors and just assigning one each account from the top? Too boring?

@jancborchardt
Copy link
Member

@xMartin yup, that’s definitely a simple and good first approach – basically what I meant above at #486 (comment) :)

@xMartin
Copy link
Member

xMartin commented Mar 27, 2020

@jancborchardt yeah, but that implies calculating difference between colors. Could you just define 8-12 color codes as a spec and then the account always have the same color counting up.

@jancborchardt
Copy link
Member

@georgehrke @skjnldsv where do we have this color list that we use in Calendar and/or in general?

@georgehrke
Copy link
Member

Calendar just generates a random color and doesn't check for color distance at the moment

@georgehrke
Copy link
Member

We have some default colors in the Nextcloud-vue color picker:
https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/ColorPicker/ColorPicker.vue#L180

@skjnldsv
Copy link
Member

@georgehrke @skjnldsv where do we have this color list that we use in Calendar and/or in general?

same, we use a hash and let it do its randomness :)
We have 18 colours iirc, so it's one chance out of 18 to get the same color again 🙈 (roughtly, my algorithm was rather good in spreading the data)

@ChristophWurst
Copy link
Member

Hey there,

I'd just like to let you know that due to the ongoing issue with Bountysource we're discussing ways to move to a different platform. As it looks right now, Bountysource might claim some of the money that was contributed by the community. We will try our best to prevent that. Historically we – the Nextcloud GmbH employees – simply put the claimed bounties back to other tickets until one was solved by a community member. So the money was always from the community and for the community. We'll therefore move to a better platform and currently don't post any new bounties until this situation is resolved. The current goal is to move/donate the money to Nextcloud include but details will follow in the forum post.

Hope this makes sense. If you have any questions please ask them on the forum. This comment will be copy-pasted to all open issues with bounties.

Christoph and the Mail team

@trougnouf
Copy link

Is there a way to define the color in SQL or some config file? I haven't found the variable so far.

@ChristophWurst
Copy link
Member

There is none, hence the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants